Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

59 set build files in a dist folder #60

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

59 set build files in a dist folder #60

wants to merge 5 commits into from

Conversation

adantoscano
Copy link
Collaborator

No description provided.

@adantoscano adantoscano added the enhancement New feature or request label Sep 12, 2023
@adantoscano adantoscano linked an issue Sep 12, 2023 that may be closed by this pull request
Set build files in a dist folder #59
Open
jorgecasar
jorgecasar reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jorgecasar jorgecasar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test javascript that is the code we are going to run.

The library expose the js files, it's a javascript library wrote in typescript. Then typescript is just a tool to get the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgecasar jorgecasar jorgecasar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set build files in a dist folder
2 participants
@adantoscano @jorgecasar