Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pwiz code base #250

Closed
lgatto opened this issue Sep 1, 2021 · 1 comment · Fixed by #253
Closed

Update pwiz code base #250

lgatto opened this issue Sep 1, 2021 · 1 comment · Fixed by #253

Comments

@lgatto
Copy link
Collaborator

lgatto commented Sep 1, 2021

This has come up several times already (see #245 and here) - there seems to be a recurrent need to update the pwiz code base in mzR. I suggest that we compile our trials and errors (I know @sneumann had a go already) in this issue so that we avoid stumbling on the same rocks over and over again.

cc @jorainer

@sneumann
Copy link
Owner

Hi, there is (another) approach to upgrade Pwiz on top of Johannes' recent branch
removing the old Ramp adapter. Not: does not support mzData anymore.
https://github.com/sneumann/mzR/tree/feature/updatePwiz_3_0_21263
Currently passing R CMD check, but no checks with downstream software yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants