Adds support for UICollectionViewCells without a nib/xib #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nil optionals (fixes crashing test)
In this case you should use NSStringFromClass on your cell class.
|
Thank you for the pull request! |
gwennguihal
reviewed
Nov 14, 2018
gwennguihal
reviewed
Dec 19, 2018
There was a problem hiding this comment.
@swoolcock Are you ok with my comments ? I would like to merge as soon as possible :)
| let nib = UINib(nibName: cellDescriptor.className, bundle: cellDescriptor.bundle) | ||
| collectionView.register(nib, forCellWithReuseIdentifier: cellDescriptor.identifier) | ||
| } | ||
| else if let cellClass = Bundle.main.classNamed(cellDescriptor.className) as? UICollectionViewCell.Type { |
There was a problem hiding this comment.
There was a problem hiding this comment.
But I can't launch tests, I opened an issue on CwlPreconditionTesting (mattgallagher/CwlPreconditionTesting#15)
There was a problem hiding this comment.
If you pull, unit tests are up.
|
Will look at it tomorrow, currently 1am in Australia :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #6
Also fixes a crashing test due to unwrapping nil optionals.