-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATProto -> ActivityPub images are not transmitted. #1000
Comments
Hmm, that's definitely worked before, and it worked in my tests. Here's an example: Bluesky post, bridged fediverse post with image is visible on @[email protected] 's timeline if you scroll down. What's your Bluesky handle? |
Well I'm following that profile for example via Bridgy on Mastodon: The Posts are basically all with image but none of them show up (it's backfilling just the text) |
Understood. Which instance are you viewing your profile on? Ie where is this screenshot from? |
Just FYI:
As you can see there's no image processing of any kind going on here |
now supports AT Protocol's DAG-JSON variant with $link and $bytes: https://atproto.com/specs/data-model. for snarfed/bridgy-fed#1000
…='atproto' for AT Protocol's DAG-JSON variant with $link and $bytes: https://atproto.com/specs/data-model ; for #1000
You sure it's fixed? |
Unrelated new error indeed. Catching up now, sorry! |
Some Bluesky posts say that images are bridged only if they have ALT. |
Example: |
@vyv03354 hmm! Definitely a bug if true, not intentional. I'll look. |
Confirmed, images with blank alt text aren't working. @vyv03354 thanks for the nudge! |
…as objects hopefully for #1000 (comment), ATProto images without alt text not showing up in AP
Fixed! Example: https://bsky.app/profile/snarfed.bsky.social/post/3ksuth5fk632i => https://indieweb.social/@[email protected]/112470182089152821 (requires login) Thanks again @vyv03354! |
@snarfed Although this issue was closed several months ago, I'm seeing it happen again. Here's an example post where I don't see an image on my instance: https://fuzzyfox.social/notes/9yhco7nc0xat05we But it does have an image on bsky: https://bsky.app/profile/did:plc:yqktid6kpzv52qfom6vgi752/post/3l4qyp5vnnm22 |
@pjreed hmm! Interesting that the image isn't visible on fuzzyfox.social. I see it on other fediverse instances, eg indieweb.social, when I search for it by https://fed.brid.gy/r/https://bsky.app/profile/did:plc:yqktid6kpzv52qfom6vgi752/post/3l4qyp5vnnm22 |
Interesting; it's possible this is somehow different. This is the most recent image I see in any post bridged from bsky, which does have alt text and is from two weeks ago: Doing a real quick skim over search results, I think the most recent image I see without alt text is from 3 months ago. |
I did a quick test from my own bsky account and can confirm that an image without alt text did not make it: https://fuzzyfox.social/notes/9yhfarnh0xat07x3 But one with alt text did: https://fuzzyfox.social/notes/9yhfbgro0xat07xj |
Interesting! Thanks for the testing. Sounds like Sharkey may be having interop trouble with Bridgy Fed. Looking at the activities, the difference is that 16,22c14,16
< "image": {
< "name": "An icon of a cartoon fox head in front of clouds",
< "type": "Image",
< "url": "https://porcini.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:i3jhyvg5pab4ac5ywqkpcuiz&cid=bafkreielmlhyb7rziwjxz4y2cvcunp2yta7wbalnmmg75dzwsquvzoiwuy"
< },
--
> "image": "https://porcini.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:i3jhyvg5pab4ac5ywqkpcuiz&cid=bafkreielmlhyb7rziwjxz4y2cvcunp2yta7wbalnmmg75dzwsquvzoiwuy", without: https://fed.brid.gy/r/https://bsky.app/profile/did:plc:i3jhyvg5pab4ac5ywqkpcuiz/post/3l4r4siwwjm2b {
"@context": "https://www.w3.org/ns/activitystreams",
"type": "Note",
"id": "https://bsky.brid.gy/convert/ap/at://did:plc:i3jhyvg5pab4ac5ywqkpcuiz/app.bsky.feed.post/3l4r4siwwjm2b",
"url": "https://fed.brid.gy/r/https://bsky.app/profile/did:plc:i3jhyvg5pab4ac5ywqkpcuiz/post/3l4r4siwwjm2b"
"attributedTo": "https://bsky.brid.gy/ap/did:plc:i3jhyvg5pab4ac5ywqkpcuiz",
"content": "<p>Testing bridging a post without alt text, ignore me!</p>",
"contentMap": {"en": "Testing bridging a post without alt text, ignore me!"},
"content_is_html": true,
"attachment": [{
"url": "https://porcini.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:i3jhyvg5pab4ac5ywqkpcuiz&cid=bafkreielmlhyb7rziwjxz4y2cvcunp2yta7wbalnmmg75dzwsquvzoiwuy"
}],
"image": "https://porcini.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:i3jhyvg5pab4ac5ywqkpcuiz&cid=bafkreielmlhyb7rziwjxz4y2cvcunp2yta7wbalnmmg75dzwsquvzoiwuy",
"published": "2024-09-22T17:34:57.917Z",
"to": ["https://www.w3.org/ns/activitystreams#Public"],
} with: https://fed.brid.gy/r/https://bsky.app/profile/did:plc:i3jhyvg5pab4ac5ywqkpcuiz/post/3l4r4thygld2u {
"@context": "https://www.w3.org/ns/activitystreams",
"type": "Note",
"id": "https://bsky.brid.gy/convert/ap/at://did:plc:i3jhyvg5pab4ac5ywqkpcuiz/app.bsky.feed.post/3l4r4thygld2u",
"url": "https://fed.brid.gy/r/https://bsky.app/profile/did:plc:i3jhyvg5pab4ac5ywqkpcuiz/post/3l4r4thygld2u"
"attributedTo": "https://bsky.brid.gy/ap/did:plc:i3jhyvg5pab4ac5ywqkpcuiz",
"content": "<p>Testing bridging a post with alt text, ignore me!</p>",
"contentMap": {
"en": "Testing bridging a post with alt text, ignore me!"
},
"content_is_html": true,
"attachment": [{
"name": "An icon of a cartoon fox head in front of clouds",
"type": "Image",
"url": "https://porcini.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:i3jhyvg5pab4ac5ywqkpcuiz&cid=bafkreielmlhyb7rziwjxz4y2cvcunp2yta7wbalnmmg75dzwsquvzoiwuy"
}],
"image": {
"name": "An icon of a cartoon fox head in front of clouds",
"type": "Image",
"url": "https://porcini.us-east.host.bsky.network/xrpc/com.atproto.sync.getBlob?did=did:plc:i3jhyvg5pab4ac5ywqkpcuiz&cid=bafkreielmlhyb7rziwjxz4y2cvcunp2yta7wbalnmmg75dzwsquvzoiwuy"
},
"published": "2024-09-22T17:35:30.468Z",
"to": ["https://www.w3.org/ns/activitystreams#Public"],
} |
Out of curiosity, do you have a way to test whether this is Sharkey-specific or also an issue with upstream Misskey? I don't have an account on a Misskey server I can easily test with... |
I'd have to test in prod like you, I don't have local *key instances that I test against. Fortunately if both are broken, fixing it on BF's side will likely fix both. |
mastodon seems to just use the attachment field, where name is
"attachment":[
{
"type":"Document",
"mediaType":"image/png",
"url":"https://files.mastodon.social/media_attachments/files/113/229/002/117/467/328/original/5adf8e3cfc7e9430.png",
"name":null,
"blurhash":"U3D,Dn}_=~%L%3NYxbt7FW-X$lRj%NjJI-s;",
"width":1055,
"height":880
}
], |
seems like we need at least |
I generally aim at simple AS2 that interops as well as possible, as opposed to "whatever Mastodon does." That way lie dragons. 😁 Actual standards are better! For this, I've made BF always emit images as objects with |
seems like images are arriving @ capivarinha.club 😄 https://capivarinha.club/notes/9yw6q32fqqa12ar9 |
Thanks, I just checked and it looks good to me now! |
It seems that Bluesky posts that have images attached do not transmit them to Mastodon. All the image posts in my feed are just text :)
The text was updated successfully, but these errors were encountered: