Fix behavior when connecting wss url without TLS support #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maugier
force-pushed
the
fix-wss-handling-when-no-tls
branch
from
1e5a9ae
to
2944367
Compare
|
Writing the test made me realize that the failure should happen earlier, before we even attempt to connect the TCP stream. I reverted the earlier patch and moved the check earlier. What do you think of this ? |
Looks very sensible, thanks! |
daniel-abramov
approved these changes
Aug 12, 2024
|
So the only job that still fails does this only due to our low MSRV, as discussed in #432 and other related issues, so I'll merge it and raise MSRV in a separate commit then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When compiled without TLS support, the client currently falls back to HTTP (and by default, on port 443) even if the URI has the
wssscheme. This creates a problem that is hard to debug, as the call fails with a generic WSS protocol error.If a
wss://URI is requested and no TLS support is available, the client should fail fast with aUrlError::TlsFeatureNotEnabled.Cheers,