remove verifyingContract from stark sig

[pscott]

Removes the verifyingContract from the stark-sig authenticator. This is done because SNIP12 does not support the verifyingContract key.
We also rename StarkEIP712 to SNIP12 for clarity.

The only important changes in this PR are:

1. Removing the verifyingContract from and updating the domain hash:

   sx-starknet/starknet/src/utils/constants.cairo

   Lines 49 to 50 in 4e8ebce

   	// StarknetKeccak('StarkNetDomain(name:felt252,version:felt252,chainId:felt252)')
   	const DOMAIN_TYPEHASH: felt252 = 0x7652a980b9a4920425c858386f09477bb210dea95169abd576f5ef7c9d5ca2;

   (check git blame)
2. Removing the contract_address from the get_domain_hash function (was previously here, you can check git blame:

   sx-starknet/starknet/src/utils/snip12.cairo

   Line 157 in 4e8ebce

   starknet::get_contract_address().serialize(ref encoded_data);

   )

The remaining are StarkEIP712 -> SNIP12. I realize now it would've been cleaner with only two distinct commits.

[Sekhmet]

@pscott could you deploy starkSig authenticator on sepolia with this removed so I could test full flow?

I remember that at some point there was some issue with either Metamask or ArgentX not being happy with verifyingContract not being passed.

[pscott]

@pscott could you deploy starkSig authenticator on sepolia with this removed so I could test full flow?

I remember that at some point there was some issue with either Metamask or ArgentX not being happy with verifyingContract not being passed.

I think it was metamask that was causing issues, but here it only concerns sx-sig so shouldn't be an issue.

New contract: 0x04a7805f0d4b34d801f2fcf7aace7bd990f3acc30e542523998f9c0d5f203055 on sepolia

[Sekhmet]

tACK (as https://sepolia.starkscan.co/contract/0x04a7805f0d4b34d801f2fcf7aace7bd990f3acc30e542523998f9c0d5f203055)