Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slot is zero check in voting strategies #624

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Jun 27, 2024

Removes Slot is zero check in the voting power strategies, and lets the error be at the space level rather than at the voting strategy level.

@pscott pscott requested a review from bonustrack July 3, 2024 11:35
@pscott pscott force-pushed the remove_slot_is_zero_assertion branch from a9e6513 to 134b4a6 Compare July 3, 2024 11:36
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@pscott pscott merged commit b206d57 into develop Aug 7, 2024
2 checks passed
@pscott pscott deleted the remove_slot_is_zero_assertion branch August 7, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants