fix: H-02 Votes Can Be Blocked #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
approved these changes
Oct 10, 2023
| @@ -473,7 +473,7 @@ describe('Ethereum Transaction Authenticator', function () { | |||
| ); | |||
| expect.fail('Should have failed'); | |||
| } catch (err: any) { | |||
| expect(err.message).to.contain(shortString.encodeShortString('Invalid sender address')); | |||
| expect(err.message).to.contain(shortString.encodeShortString('Commit not found')); | |||
| } | |||
There was a problem hiding this comment.
could we add a test that tests the "attack" vector that OZ mentioned? Just to add it as a regression test for later work
There was a problem hiding this comment.
yeah sorry added but forgot to push
I had a think about the other approach but not sure its really feasible as it would mean computing the hash on-chain in order to include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
_commits(commit -> address) mapping with a double mapping (commit, address -> bool).This allows the same commit to be made by 2 different addresses, which wasn't possible before.
This closes #555 as now its impossible for a user to block another by making a valid commit for their action before they do.