refactor: N-02 Code Clarity Suggestions #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 6, 2023 11:48
1 task
pscott
approved these changes
Oct 6, 2023
| @@ -32,15 +32,12 @@ mod MerkleWhitelistVotingStrategy { | |||
| params: Span<felt252>, // [root: felt252] | |||
| user_params: Span<felt252>, // [leaf: Leaf, proof: Array<felt252>] | |||
| ) -> u256 { | |||
| let cache = user_params; // cache | |||
| let mut params = params; | |||
There was a problem hiding this comment.
you can add mut keywrods to the params and user_params arguments directly, no need to re-bind :D
There was a problem hiding this comment.
oh nice, updated. think there some other situations where we can do this. will have a look
| @@ -47,7 +47,7 @@ impl StoreFelt252Array of Store<Array<felt252>> { | |||
| offset += 1; | |||
|
|
|||
| // Sequentially read all stored elements and append them to the array. | |||
| let exit = len + offset; | |||
| let exit = len * Store::<felt252>::size() + offset; | |||
There was a problem hiding this comment.
I did this, what do you think 73a9269 ?
There was a problem hiding this comment.
yeah thanks, that makes a lot of sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #564