-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for proposals with pending results #1055
Conversation
0eca2bc
to
cacab7b
Compare
cacab7b
to
816e89e
Compare
Any idea why these proposal are stuck with results not finalized? Is just proposal with invalid score? |
We should show the logo Shutter on proposals with Privacy |
Proposals are stuck for various reasons:
There's currently ~260 closed proposals with pending state. Will trigger the score finalization manually. We should have a somewhere to ensure the finalization is triggered in case webhook is lost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, how do we trigger webhook? I visited your proposal on v1 to see how it's handled there and it looks like it triggered decryption.
Do we trigger it from the UI? If that's the case then we probably should bring back that trigger to new UI, otherwise we won't trigger it 🤔
Computation is triggered via webhook, on proposal close, everything is done on backend, no more trigger for that from the UI. There's a few cases where finalization trigger are missed, as webhook are not retried on error, need to work on a solution to ensure all trigger is called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/332
This PR adds support for offchain proposals with pending results (when
scores_state
is notfinal
)Pending score happens for:
How to test
On proposal with privacy
On proposal without privacy
Note
We don't support when the proposal has
scores_state
asinvalid
state, since it's not handled on v1 either