fix: remove extra hash in explorer URL

snapshot-labs · Jan 22, 2025 · 0c07bae · 0c07bae
1 parent 77928ce
commit 0c07bae
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 30 deletions.
diff --git a/scripts/addNetwork.ts b/scripts/addNetwork.ts
@@ -27,7 +27,7 @@ const network = {
   multicall,
   rpc: [],
   explorer: {
-    url: explorer
+    url: explorer.replace(/\/$/, '')
   },
   start: parseInt(start, 10),
   logo: `ipfs://${logo}`

diff --git a/src/networks.json b/src/networks.json
@@ -403,7 +403,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://explorer.evm.shimmer.network/"
+      "url": "https://explorer.evm.shimmer.network"
     },
     "start": 1290,
     "logo": "ipfs://bafkreib4xhbgbhrwkmizp4d4nz3wzbpyhdm6wpz2v2pbkk7jxsgg3hdt74"
@@ -417,7 +417,7 @@
     "multicall": "0xA4029b74FBA366c926eDFA7Dd10B21C621170a4c",
     "rpc": [],
     "explorer": {
-      "url": "https://puppyscan.shib.io/"
+      "url": "https://puppyscan.shib.io"
     },
     "start": 3035769,
     "logo": "ipfs://bafkreig57igai5phg4icywc5yoockd52jo3hlvbkyi6wiufrmu4p2lmenm",
@@ -446,7 +446,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "http://opbnbscan.com/"
+      "url": "http://opbnbscan.com"
     },
     "start": 512881,
     "logo": "ipfs://bafkreibll4la7wqerzs7zwxjne2j7ayynbg2wlenemssoahxxj5rbt6c64"
@@ -527,7 +527,7 @@
     "multicall": "0xF9cda624FBC7e059355ce98a31693d299FACd963",
     "rpc": [],
     "explorer": {
-      "url": "https://sepolia.explorer.zksync.dev/"
+      "url": "https://sepolia.explorer.zksync.dev"
     },
     "start": 2292,
     "logo": "ipfs://bafkreih6y7ri7h667cwxe5miisxghfheiidtbw2747y75stoxt3gp3a2yy",
@@ -577,7 +577,7 @@
       "https://mainnet.era.zksync.io"
     ],
     "explorer": {
-      "url": "https://explorer.zksync.io/"
+      "url": "https://explorer.zksync.io"
     },
     "start": 3908235,
     "logo": "ipfs://bafkreih6y7ri7h667cwxe5miisxghfheiidtbw2747y75stoxt3gp3a2yy"
@@ -610,7 +610,7 @@
       "https://rpc.pulsechain.com"
     ],
     "explorer": {
-      "url": "https://scan.pulsechain.com/"
+      "url": "https://scan.pulsechain.com"
     },
     "start": 17657774,
     "logo": "ipfs://QmWUsiEWdejtHZ9B9981TYXn7Ds8C7fkB1S4h5rP3kCCZR"
@@ -739,7 +739,7 @@
       "https://archive.evm.testnet.shimmer.network/v1/chains/rms1pr75wa5xuepg2hew44vnr28wz5h6n6x99zptk2g68sp2wuu2karywgrztx3/evm"
     ],
     "explorer": {
-      "url": "https://explorer.evm.testnet.shimmer.network/"
+      "url": "https://explorer.evm.testnet.shimmer.network"
     },
     "start": 10614,
     "logo": "ipfs://bafkreihtwfwrue7klzedwx4rqlk6agklz4lbbk7owsyw6xzn6c2m4t5tgy"
@@ -801,7 +801,7 @@
       "https://rpc.api.moonbeam.network"
     ],
     "explorer": {
-      "url": "https://moonscan.io/"
+      "url": "https://moonscan.io"
     },
     "start": 171135,
     "logo": "ipfs://QmWKTEK2pj5sBBbHnMHQbWgw6euVdBrk2Ligpi2chrWASk"
@@ -863,7 +863,7 @@
     "multicall": "0xe033Bed7cae4114Af84Be1e9F1CA7DEa07Dfe1Cf",
     "rpc": [],
     "explorer": {
-      "url": "https://seitrace.com/"
+      "url": "https://seitrace.com"
     },
     "start": 79164574,
     "logo": "ipfs://bafkreiammyt7uztbztqbcqv4bydnczsh2fqmnjf6jxj4xnskzzl6sjrigq"
@@ -877,7 +877,7 @@
     "multicall": "0xD8d2dFca27E8797fd779F8547166A2d3B29d360E",
     "rpc": [],
     "explorer": {
-      "url": "https://islander.vanascan.io/"
+      "url": "https://islander.vanascan.io"
     },
     "start": 716763,
     "logo": "ipfs://bafkreibotel3dmc5og5rf3tpt7l74awkene7x6q3oxtwhptt4y4rpa7vsa"
@@ -999,7 +999,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://kavascan.com/"
+      "url": "https://kavascan.com"
     },
     "start": 3661165,
     "logo": "ipfs://bafkreibpfubharx32fjqkqbfdhygwdjb2khxdg6meaasrcxsgvowos26f4"
@@ -1029,7 +1029,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://holesky.fraxscan.com/"
+      "url": "https://holesky.fraxscan.com"
     },
     "start": 1,
     "logo": "ipfs://bafkreieflj4wq6tx7k5kq47z3xnsrdrn2xgm4bxa3uovrnndcb2vqqwlyu",
@@ -1044,7 +1044,7 @@
     "multicall": "0xc454132B017b55b427f45078E335549A7124f5f7",
     "rpc": [],
     "explorer": {
-      "url": "https://peaq.subscan.io/"
+      "url": "https://peaq.subscan.io"
     },
     "start": 3525964,
     "logo": "ipfs://bafkreidqkleori7pmilesz4t52iebebaqf3oflzmoz646qfuaznanb3sgm"
@@ -1072,7 +1072,7 @@
     "multicall": "0x4956F15eFdc3dC16645e90Cc356eAFA65fFC65Ec",
     "rpc": [],
     "explorer": {
-      "url": "https://subnets.avax.network/beam/"
+      "url": "https://subnets.avax.network/beam"
     },
     "start": 1,
     "logo": "ipfs://QmaKRLxXPdeTsLx7MFLS3CJbhpSbResgoeL4fCgHB1mTsF"
@@ -1228,7 +1228,7 @@
     "multicall": "0xca11bde05977b3631167028862be2a173976ca11",
     "rpc": [],
     "explorer": {
-      "url": "https://basescan.org/"
+      "url": "https://basescan.org"
     },
     "start": 5022,
     "logo": "ipfs://QmaxRoHpxZd8PqccAynherrMznMufG6sdmHZLihkECXmZv"
@@ -1261,7 +1261,7 @@
     "multicall": "0xc454132B017b55b427f45078E335549A7124f5f7",
     "rpc": [],
     "explorer": {
-      "url": "https://agung-testnet.subscan.io/"
+      "url": "https://agung-testnet.subscan.io"
     },
     "start": 2031789,
     "logo": "ipfs://bafkreidqkleori7pmilesz4t52iebebaqf3oflzmoz646qfuaznanb3sgm",
@@ -1309,7 +1309,7 @@
     "multicall": "0x9BF49b704EE2A095b95c1f2D4EB9010510c41C9E",
     "rpc": [],
     "explorer": {
-      "url": "https://subnets-test.avax.network/beam/"
+      "url": "https://subnets-test.avax.network/beam"
     },
     "start": 3,
     "logo": "ipfs://QmaKRLxXPdeTsLx7MFLS3CJbhpSbResgoeL4fCgHB1mTsF",
@@ -1415,7 +1415,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://apechain.calderaexplorer.xyz/"
+      "url": "https://apechain.calderaexplorer.xyz"
     },
     "start": 20889,
     "logo": "ipfs://bafkreielbgcox2jsw3g6pqulqb7pyjgx7czjt6ahnibihaij6lozoy53w4"
@@ -1448,7 +1448,7 @@
       "https://arbitrum-nova.public.blastapi.io"
     ],
     "explorer": {
-      "url": "https://nova.arbiscan.io/"
+      "url": "https://nova.arbiscan.io"
     },
     "start": 6006607,
     "logo": "ipfs://bafkreie5xsqt3mrrwu7v32qpmmctibhzhgxf4emfzzddsdhdlfsa7fmplu"
@@ -1514,7 +1514,7 @@
       "https://rpc.rei.network"
     ],
     "explorer": {
-      "url": "https://scan.rei.network/"
+      "url": "https://scan.rei.network"
     },
     "start": 1715902,
     "logo": "ipfs://QmTogMDLmDgJjDjUKDHDuc2KVTVDbXf8bXJLFiVe8PRxgo"
@@ -1529,7 +1529,7 @@
       "https://subnets.avax.network/defi-kingdoms/dfk-chain/rpc"
     ],
     "explorer": {
-      "url": "https://subnets.avax.network/defi-kingdoms/"
+      "url": "https://subnets.avax.network/defi-kingdoms"
     },
     "start": 62,
     "logo": "ipfs://QmZNkpVgPbuVbDcsi6arwH1om3456FGnwfDqYQJWUfHDEx"
@@ -1558,7 +1558,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://sepolia.lineascan.build/"
+      "url": "https://sepolia.lineascan.build"
     },
     "start": 227427,
     "logo": "ipfs://bafkreihtyzolub3sejuwc32hpdpjnt7ksowaguni2yuho3kyihhcqrtqce",
@@ -1573,7 +1573,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://lineascan.build/"
+      "url": "https://lineascan.build"
     },
     "start": 42,
     "logo": "ipfs://bafkreihtyzolub3sejuwc32hpdpjnt7ksowaguni2yuho3kyihhcqrtqce"
@@ -1608,7 +1608,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://amoy.polygonscan.com/"
+      "url": "https://amoy.polygonscan.com"
     },
     "start": 3127388,
     "logo": "ipfs://bafkreibfiyvhqnme2vbxxfcku7qkxgjpkg6ywdkplxh4oxlkqsbznyorfm",
@@ -1637,7 +1637,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://base-sepolia.blockscout.com/"
+      "url": "https://base-sepolia.blockscout.com"
     },
     "start": 1059647,
     "logo": "ipfs://QmaxRoHpxZd8PqccAynherrMznMufG6sdmHZLihkECXmZv",
@@ -1696,7 +1696,7 @@
     "multicall": "0x97148F8fDdd9A1620f72EC1Bb2932916623d9da5",
     "rpc": [],
     "explorer": {
-      "url": "https://sepolia.explorer.zklink.io/"
+      "url": "https://sepolia.explorer.zklink.io"
     },
     "start": 43723,
     "logo": "ipfs://bafkreic6c3iems5235qapyhyrygha7akqrsfact2nok3y2uhljpzxrdu74",
@@ -1749,7 +1749,7 @@
     "multicall": "0xffc391F0018269d4758AEA1a144772E8FB99545E",
     "rpc": [],
     "explorer": {
-      "url": "https://testnet.cyberscan.co/"
+      "url": "https://testnet.cyberscan.co"
     },
     "start": 304545,
     "logo": "ipfs://bafkreifm2bbehoqpz4454o7gixnxfi6cgvqlxigqr3f6ipj7l2omtgfgnm",
@@ -1779,7 +1779,7 @@
     "multicall": "0xcA11bde05977b3631167028862bE2a173976CA11",
     "rpc": [],
     "explorer": {
-      "url": "https://devnet.neonscan.org/"
+      "url": "https://devnet.neonscan.org"
     },
     "start": 205206112,
     "logo": "ipfs://QmecRPQGa4bU7tybg1sUQY48Md9rWnmhrT6WW5ueqvhg6P",
@@ -1840,4 +1840,4 @@
     "start": 7521509,
     "logo": "ipfs://QmNnGPr1CNvj12SSGzKARtUHv9FyEfE5nES73U4vBWQSJL"
   }
-}
+}
diff --git a/test/e2e/network.spec.ts b/test/e2e/network.spec.ts
@@ -0,0 +1,12 @@
+import networks from '../../src/networks.json';
+import { test, expect, describe } from 'vitest';
+
+describe('test networks.json file', () => {
+  test('explorer endpoint should not end with a /', () => {
+    expect(
+      Object.values(networks).every(
+        (network) => !network.explorer.url.endsWith('/')
+      )
+    ).toBe(true);
+  });
+});