fix: Fix incorrect Promise structure in customFetch timeout logic #1652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update resolves an issue in the
customFetch
function where the second promise in thePromise.race
block was constructed incorrectly. Previously, it usednew Promise(() => ...)
, which omitted the requiredresolve
andreject
arguments for the executor function. This omission could lead to runtime errors as the promise neither resolves nor rejects upon timeout.The corrected implementation ensures proper handling by rejecting the promise when the timeout occurs:
This change improves reliability and ensures errors are properly propagated during timeout scenarios.