Fix variable shadowing in getDelegations #1644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the provided code, there was a potential issue with variable shadowing in the
getDelegations
function. Specifically, the parameteraddresses
was used as the name of the array and then reused inside themap
method, which could lead to confusion. This issue was fixed by renaming the inner variable in themap
method.The error:
The fix:
This change improves code readability and prevents potential bugs related to variable shadowing, ensuring that the code is easier to maintain and understand.