Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[synthetix] fix: fix invalid block value passed to thegraph #1399

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[synthetix] fix: fix invalid block value passed to thegraph #1399

merged 2 commits into from
Jan 31, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jan 31, 2024 •
edited
Loading

Fixes #1335

Changes proposed in this pull request:

  • When passing block number to the graph, only pass when it's a number, ignore if block == latest, as block only accept a number

@wa0x6e wa0x6e requested a review from ChaituVR January 31, 2024 11:29
@wa0x6e wa0x6e changed the title fix: fix invalid block value passed to thegraph [synthetix] fix: fix invalid block value passed to thegraph Jan 31, 2024
ChaituVR
ChaituVR approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 587bc38 into master Jan 31, 2024
5 checks passed
@ChaituVR ChaituVR deleted the synthetix-fix-invalid-snapshot-value branch January 31, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
strategy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: invalid latest snapshot is passed to thegraph.com
2 participants
@wa0x6e @ChaituVR