Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spacefi-blp] add blp strategy #1394

Merged
merged 9 commits into from
Jan 25, 2024
Merged

[spacefi-blp] add blp strategy #1394

merged 9 commits into from
Jan 25, 2024

Conversation

SpaceFinance
Copy link
Contributor

Fixes # .

Changes proposed in this pull request:

ChaituVR
ChaituVR requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SpaceFinance Could you please add a readme to this strategy? will help users know more about it

@SpaceFinance
Copy link
Contributor Author

Hi @SpaceFinance Could you please add a readme to this strategy? will help users know more about it

Added, please check

ChaituVR
ChaituVR requested changes Jan 23, 2024
View reviewed changes
src/strategies/spacefi-blp/index.ts Outdated Show resolved Hide resolved
src/strategies/spacefi-blp/index.ts Outdated Show resolved Hide resolved
@ChaituVR ChaituVR changed the title add blp strategy [spacefi-blp] add blp strategy Jan 23, 2024
ChaituVR
ChaituVR requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add strategy to /src/strategies/index.ts like all other strategies

@SpaceFinance
Copy link
Contributor Author

should add strategy to /src/strategies/index.ts like all other strategies

Added Completed

@ChaituVR
Copy link
Member

Tests are failing can take a look? try running yarn test --strategy=spacefi-blp --more=500 in your local

@SpaceFinance
Copy link
Contributor Author

Tests are failing can take a look? try running yarn test --strategy=spacefi-blp --more=500 in your local

Modified, please check

@ChaituVR ChaituVR merged commit 7363102 into snapshot-labs:master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
strategy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpaceFinance @ChaituVR