Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[station-score-if-badge, station-constant-if-badge, mangrove-station-qv-scaled-to-mgv] Update ERC-6551 ABI #1373

Merged
merged 2 commits into from
Dec 17, 2023
Merged

[station-score-if-badge, station-constant-if-badge, mangrove-station-qv-scaled-to-mgv] Update ERC-6551 ABI #1373

merged 2 commits into from
Dec 17, 2023

Conversation

espendk
Copy link
Contributor

@espendk espendk commented Dec 14, 2023 •
edited
Loading

The ordering of the ERC-6551 account function parameters has changed and the salt parameter is now a bytes32 instead of a uint256.

This PR updates the station-score-if-badge strategy and its dependents station-constant-if-badge and mangrove-station-qv-scaled-to-mgv accordingly.

@espendk
[station-score-if-badge, station-constant-if-badge, mangrove-station-…
4ed3fda 
…qv-scaled-to-mgv] Update ERC-6551 ABI

The ordering of the ERC-6551 'account' function parameters has changed and the 'salt' is now a bytes32 instead of a uint256.
This commit updates the station-score-if-badge and its dependents station-constant-if-badge and mangrove-station-qv-scaled-to-mgv accordingly.
@espendk
chore: Fix linting error
082c969
ChaituVR
ChaituVR requested changes Dec 17, 2023
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @espendk Could you plz create seperate PRs for each strategy, it will be easy to review/test/integrate

@espendk
Copy link
Contributor Author

espendk commented Dec 17, 2023

Hi @espendk Could you plz create seperate PRs for each strategy, it will be easy to review/test/integrate

@ChaituVR I'm not sure how to do that in a good way: If I split this PR into three, then the first PR would be the changes to station-score-if-badge which would break the two dependent strategies.

Is that acceptable or do you see a better way?

@ChaituVR ChaituVR changed the title [station-score-if-badge, station-constant-if-badge, mangrove-station-qv-scaled-to-mgv] Update ERC-6551 ABI [station-score-if-badge] Update ERC-6551 ABI Dec 17, 2023
@ChaituVR ChaituVR changed the title [station-score-if-badge] Update ERC-6551 ABI [mangrove-station-qv-scaled-to-mgv] Update ERC-6551 ABI Dec 17, 2023
@ChaituVR ChaituVR removed the strategy label Dec 17, 2023
@ChaituVR ChaituVR changed the title [mangrove-station-qv-scaled-to-mgv] Update ERC-6551 ABI [station-score-if-badge, station-constant-if-badge, mangrove-station-qv-scaled-to-mgv] Update ERC-6551 ABI Dec 17, 2023
@ChaituVR ChaituVR merged commit 215c357 into snapshot-labs:master Dec 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@espendk @ChaituVR