Refactor bot command definition style #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsaaes
suggested changes
Oct 25, 2022
|
I've made some new modifications regarding your comments. Could you please check again @parsaaes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new style to define new bot commands, which I believe is more human-readable and easier to maintain.
With this model, each command will have a file in the
commandandmessagepackages representing the command definition and its message templates.For pattern matching, each command will have to define a regular expression for it's command messages in a
Match(message string) boolfunction. It must also have aHandle(event *gomatrix.Event) errorfor command handling.This PR is not ready for merge. We need to migrate all commands to the new style if the new style is acceptable.