Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/s3 sub user #16

Merged
merged 36 commits into from
Nov 6, 2023
Merged

Feature/s3 sub user #16

merged 36 commits into from
Nov 6, 2023

Conversation

hoptical
Copy link
Collaborator

Closes #15

@hoptical hoptical added the enhancement New feature or request label Oct 29, 2023
@hoptical hoptical self-assigned this Oct 29, 2023
@hoptical hoptical marked this pull request as ready for review November 3, 2023 16:08
@hoptical hoptical requested a review from therealak12 November 3, 2023 16:08
@hoptical
Copy link
Collaborator Author

hoptical commented Nov 3, 2023

@therealak12 the make test step is failing. Please check it. I couldn't find the issue.
Thanks in advance for your review.

api/v1alpha1/s3userclaim_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/s3userclaim_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/s3userclaim_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/s3userclaim_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/types.go Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/handler.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/handler.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
internal/controllers/s3userclaim/provisioner.go Outdated Show resolved Hide resolved
@hoptical
Copy link
Collaborator Author

hoptical commented Nov 4, 2023

@therealak12
I've used both subuser and subUser conventions in the code. What do you say about using only subuser form?

Copy link
Member

@therealak12 therealak12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (please fix the BucketAccessAction name). Thanks Dear Hamed 🏵️.

I think it would be nice if you or someone else could also take a look at the changes. I might have missed details.

@therealak12
Copy link
Member

@therealak12 I've used both subuser and subUser conventions in the code. What do you say about using only subuser form?

I see subuser in Ceph docs. This may justify using subuser!

@hoptical
Copy link
Collaborator Author

hoptical commented Nov 4, 2023

Approved (please fix the BucketAccessAction name). Thanks Dear Hamed 🏵️.

I think it would be nice if you or someone else could also take a look at the changes. I might have missed details.

Thanks, Dear Ahmad,
I fixed it.
Sure, I will ask. Thanks again.

@hoptical
Copy link
Collaborator Author

hoptical commented Nov 4, 2023

@therealak12 I've used both subuser and subUser conventions in the code. What do you say about using only subuser form?

I see subuser in Ceph docs. This may justify using subuser!

Nice. I'll make the change.

@hoptical hoptical requested a review from 1995parham November 5, 2023 07:24
@hoptical
Copy link
Collaborator Author

hoptical commented Nov 5, 2023

@therealak12 I've used both subuser and subUser conventions in the code. What do you say about using only subuser form?

I see subuser in Ceph docs. This may justify using subuser!

Nice. I'll make the change.

Done.

@hoptical hoptical merged commit d599a76 into main Nov 6, 2023
3 checks passed
@hoptical hoptical deleted the feature/s3SubUser branch November 8, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Adding bucket policy and sub-user support to the operator
3 participants