Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow QuickCheck 2.15 and lens 5.3; bump cabal CI to GHC 9.10 #151

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

andreasabel
Copy link
Contributor

@andreasabel andreasabel commented Jul 2, 2024

Not sure why CI does not run here. It runs at: andreasabel#1

@andreasabel
Copy link
Contributor Author

andreasabel commented Jul 2, 2024

A test fails because for GHC > 9.0 it prints a longer call stack now:

expected: ["templates-bad/apply-missing-attr.tpl: must supply "template" attribute in \nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in main:Heist.Common","templates-bad/apply-template-not-found.tpl: apply tag cannot find template "/page"\nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in main:Heist.Common","templates-bad/bind-infinite-loop.tpl: template recursion exceeded max depth, you probably have infinite splice recursion!\nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in main:Heist.Common","templates-bad/bind-missing-attr.tpl: must supply "tag" attribute in \nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in main:Heist.Common"]

but got: ["templates-bad/apply-missing-attr.tpl: must supply "template" attribute in \nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in heist-1.1.1.2-inplace-testsuite:Heist.Common","templates-bad/apply-template-not-found.tpl: apply tag cannot find template "/page"\nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in heist-1.1.1.2-inplace-testsuite:Heist.Common","templates-bad/bind-infinite-loop.tpl: template recursion exceeded max depth, you probably have infinite splice recursion!\nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in heist-1.1.1.2-inplace-testsuite:Heist.Common","templates-bad/bind-missing-attr.tpl: must supply "tag" attribute in \nCallStack (from HasCallStack):\n error, called at src/Heist/Common.hs:76:15 in heist-1.1.1.2-inplace-testsuite:Heist.Common"]

https://github.com/andreasabel/heist/actions/runs/9762690081/job/26946755840?pr=1#step:10:116

@andreasabel
Copy link
Contributor Author

Published as heist-1.1.1.2 revision 2.

@andreasabel andreasabel mentioned this pull request Jul 2, 2024
49 tasks
@cydparser
Copy link
Contributor

Thanks!

GitHub automatically disables checks after a repo is inactive for too long. I've re-enabled them (again).

@cydparser cydparser merged commit 07d7ac2 into snapframework:master Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants