Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata and readme cleanup #20

Merged
merged 3 commits into from
Nov 19, 2022
Merged

Metadata and readme cleanup #20

merged 3 commits into from
Nov 19, 2022

Conversation

merlijn-sebrechts
Copy link
Member

No description provided.

@merlijn-sebrechts merlijn-sebrechts requested review from a team and tunix and removed request for a team November 16, 2022 16:52
lucyllewy
lucyllewy previously approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@lucyllewy lucyllewy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucyllewy lucyllewy dismissed their stale review November 16, 2022 17:19

Looks like it fails to build

lucyllewy
lucyllewy approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@lucyllewy lucyllewy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've forced the version of irrlicht to match the version that minetest is expecting. So LGTM again. Need someone else to confirm because I added the latest commit and I'm not allowed to approve my own work :-)

@merlijn-sebrechts
Copy link
Member Author

Ok, good to know, thanks!

BTW, I can't approve it either because it's my own PR.

@merlijn-sebrechts merlijn-sebrechts merged commit e4c7a06 into snapcrafters:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucyllewy lucyllewy lucyllewy approved these changes

@tunix tunix Awaiting requested review from tunix tunix was automatically assigned from snapcrafters/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merlijn-sebrechts @lucyllewy