Add libstdc++6 #66
Add libstdc++6 #66
Conversation
|
@popey Does this solve the issue? I am not familiar with the syntax of snap config. I could not find the config for Ubuntu 18, but this library should be added in that config too (if missing). |
|
Thanks very much for the pull request. I don’t have the ability to reproduce the issue right now. I have published a build of the snap incorporating your fix in a branch. Please could you install the build on a clean system, or if you have the snap already installed, refresh to this branch, and test it?
or:
If you’re happy with the fix, I’ll land this PR. Thanks again! |
|
@popey I ran the tests using this branch, and it seems to work. So, if you can merge this that would be great. I need to get user's feedback too since I am not mainly on Ubuntu. https://github.com/atom-community/zadeh/runs/1660884233#step:9:11 |
|
@DeeDeeG Could you do a test for us? For example, see if |
|
@aminya I'm looking over the PR and related conversations so I can see what exactly I should expect, what needs testing, and so on. |
|
@aminya once I have |
If no error similar to #65 is thrown in Atom or in the dev tools then it means it is working. You can also try autocomplete-path package |
|
I loaded the regular With (I don't think the person reporting that issue left us clear steps to reproduce, so I'm not sure what problem they were seeing. It almost sounds like they had a really old OS/ old libc, installed a newer OS over it but preserving their home directory... so in their |
|
On the positive side: I think their issue is not due to the package or the snap, so it's likely not our responsibility to fix. Probably the greatest amount of end-user trouble and confusion in the Atom world comes from natively built package binaries that were built against some other target than they are being initialized on... |
|
I had a bunch of nifty language-aware autocomplete suggestions when editing a new file |
|
@popey this PR is ready to merge |
|
@aminya it's working for me on the stable branch of the I think my testing implies this PR isn't needed. |
|
Maybe you already have the library installed on your machine. I still think this PR should be merged. |
|
The person who reported the initial issue said they were "distro hopping" which means installing lots of different Linux OSes. I think they must have installed OSes with two different versions of I really don't see a way that the Atom snap is related to that issue. |
|
I guess I can try on Ubuntu 20.04.1 instead of Ubuntu 20.10... |
|
This issue was reported 13 times by 13 different people. See all the duplicates I closed. The fact that it does not happen for you does not mean that this library is not needed. |
|
Well I'm also unable to reproduce this on kubuntu 20.04.1, which (20.04.1 in general) is what all the other reports were from. Sadly I can't test the Atom version they all reported this from, Atom 1.53.0, as the newer version is out 1.54.0, and snap won't let me install the old version unless I have developer access (uploading rights?) to the Atom snap. I have no idea if this fix is needed or not, and unless someone gives me steps that work for me to actually reproduce the issue it will be unclear to me whether this fix is relevant. I can't say either way based on any evidence or testing. |
|
@popey Could you merge this? I have been waiting for it for a long time now. |
|
@popey @snapcrafters @flexiondotorg could you merge this? |
|
Anyone here? |
Hopefully, fixes #65