Keydown improvements #1604
Merged
Keydown improvements #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2017 13:40
Rely on index within selectable lis instead of index within siblings
Only filter items when necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a couple of issues with using the up/down keys: #1603
I don't know exactly what was causing the issue but I've resolved it by reworking the way it gets the index. The code is much simpler and should be more robust.
I also improved the performance of the keydown function by only selecting the $items when needed. This helps both when using the arrow keys and when typing in the livesearch in a very large list. Note I've removed the code that applies a filter based on the livesearch as it didn't appear to be used - I assume it was left over from an older version.