Use undefined object and jQuery trigger method #1356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| isOptgroup = this.parentNode.tagName === 'OPTGROUP', | ||
| isDisabled = this.disabled || (isOptgroup && this.parentNode.disabled); | ||
|
|
||
| if (icon !== '' && isDisabled) { | ||
| icon = '<span>' + icon + '</span>'; | ||
| } | ||
|
|
||
| if (that.options.hideDisabled && (isDisabled && !isOptgroup || this.parentNode.disabled && isOptgroup)) { | ||
| if (that.options.hideDisabled && isDisabled) { |
There was a problem hiding this comment.
This line needs to be that.options.hideDisabled && (isDisabled && !isOptgroup || this.parentNode.disabled && isOptgroup). With just that.options.hideDisabled && isDisabled, if an optgroup has a disabled option in it, the optgroup's header is hidden. I guess we could make a variable called something like isOptgroupDisabled and set it equal to this.parentNode.disabled && isOptgroup, and then set the if statement to if (that.options.hideDisabled && (isDisabled && !isOptgroup || isOptgroupDisabled)).
|
@caseyjhol better looks now? |
| liIndex--; | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
This needs to remain, otherwise disabled options within an optgroup stay visible.
caseyjhol
added a commit
that referenced
this pull request
May 13, 2016
address some items from #1356
vsn4ik
referenced
this pull request
Sep 13, 2016
jQuery 3.0 introduced a breaking change in the empty value of multi select boxes. For details, see https://jquery.com/upgrade-guide/3.0/#breaking-change-select-multiple-with-nothing-selected-returns-an-empty-array
avantika-gupta-jtg
pushed a commit
to JoshLabs/bootstrap-select
that referenced
this pull request
May 14, 2020
address some items from snapappointments#1356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$.fn.triggerfor unification. Deprecate event shorthand methods (jQuery v4, Deprecate event shorthand methods jquery/jquery#3214)