Don't render checkMark (tickIcon) if showTick is false or the select …

…is not multiple (#1425, #1426). Mild performance boost.
snapappointments · Oct 15, 2018 · b8fadf6 · b8fadf6
1 parent 92f643f
commit b8fadf6
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/js/bootstrap-select.js b/js/bootstrap-select.js
@@ -941,11 +941,15 @@
           li: document.createElement('li'),
           whitespace: document.createTextNode("\u00A0")
         },
-        checkMark = elementTemplates.span.cloneNode(false),
+        checkMark,
         fragment = document.createDocumentFragment();
 
-      checkMark.className = that.options.iconBase + ' ' + that.options.tickIcon + ' check-mark';
-      elementTemplates.a.appendChild(checkMark);
+      if (that.options.showTick || that.multiple) {
+        checkMark = elementTemplates.span.cloneNode(false);
+        checkMark.className = that.options.iconBase + ' ' + that.options.tickIcon + ' check-mark';
+        elementTemplates.a.appendChild(checkMark);
+      }
+
       elementTemplates.a.setAttribute('role', 'option');
 
       elementTemplates.subtext.className = 'text-muted';