Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use peppy #22

Closed
wants to merge 5 commits into from
Closed

use peppy #22

wants to merge 5 commits into from

Conversation

stolarczyk
Copy link

@stolarczyk stolarczyk commented Mar 2, 2020

@vreuter, @nsheff, @johanneskoester

This is a reiteration of #8, but with a re-written version of peppy that supports the config format revamp discussed in pepkit/peppy#334

rules/common.smk Outdated
Comment on lines 10 to 12
p = Project(cfg="prjcfg.yaml", sample_table_index="sample",
subsample_table_index=["sample", "unit"])

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample_table_index and subsample_table_index arguments could be skipped if snakemake followed peppy defaults:

  • "sample_name" for sample_table index colnames
  • ["sample_name", "subsample_name"] for subsample_table index colnames

@nsheff
Copy link

nsheff commented May 21, 2020

@stolarczyk can you update this to the now-almost-final peppy updates when you get a chance?

@nsheff
Copy link

nsheff commented Jun 2, 2020

Hi @johanneskoester can you take a look at this when you get a moment?

@nsheff
Copy link

nsheff commented Jun 2, 2020

FYI we released peppy so it's now live with all the updates we discussed.

@johanneskoester
Copy link
Contributor

Hi Nathan,
yes, I'll have a look. Still not a fan of the snake_config tag, but maybe it can be used in a different way. I just cannot promise that I will be able to evaluate it immediately.

Best,
Johanne

@nsheff
Copy link

nsheff commented Jun 3, 2020

Still not a fan of the snake_config tag

that's not build in to peppy -- it's just used here. you could instead just put all options in config.yaml directly into the PEP... is that what you're wanting?

@johanneskoester
Copy link
Contributor

Thanks for the clarification! I will probably keep the PEP and the pipeline config separate then. My idea is that the PEP should just describe the samples, while the pipeline describes the analysis. This way, one can easily plug the very same PEP into a completely different pipeline (other WMS, other analysis, ...).

@johanneskoester johanneskoester deleted the branch snakemake-workflows:master April 9, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants