-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use peppy #22
use peppy #22
Conversation
rules/common.smk
Outdated
p = Project(cfg="prjcfg.yaml", sample_table_index="sample", | ||
subsample_table_index=["sample", "unit"]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sample_table_index
and subsample_table_index
arguments could be skipped if snakemake followed peppy
defaults:
"sample_name"
for sample_table index colnames["sample_name", "subsample_name"]
for subsample_table index colnames
@stolarczyk can you update this to the now-almost-final peppy updates when you get a chance? |
Hi @johanneskoester can you take a look at this when you get a moment? |
FYI we released peppy so it's now live with all the updates we discussed. |
Hi Nathan, Best, |
that's not build in to peppy -- it's just used here. you could instead just put all options in |
Thanks for the clarification! I will probably keep the PEP and the pipeline config separate then. My idea is that the PEP should just describe the samples, while the pipeline describes the analysis. This way, one can easily plug the very same PEP into a completely different pipeline (other WMS, other analysis, ...). |
@vreuter, @nsheff, @johanneskoester
This is a reiteration of #8, but with a re-written version of
peppy
that supports the config format revamp discussed in pepkit/peppy#334