Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move port search variables to consts rather than in-line #975

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

Page-
Copy link
Member

@Page- Page- commented Jan 27, 2021

No description provided.

@Page- Page- requested a review from hemberger January 27, 2021 11:46
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #975 (26d59bd) into master (1f21ed5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #975   +/-   ##
========================================
  Coverage      2.75%   2.75%           
  Complexity     4062    4062           
========================================
  Files            74      74           
  Lines         11200   11200           
========================================
  Hits            308     308           
  Misses        10892   10892           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f21ed5...26d59bd. Read the comment docs.

Copy link
Member

@hemberger hemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, great idea! Suggestions below are just to fix underscore consistency, but otherwise I approve.

src/config.php Outdated Show resolved Hide resolved
src/engine/Default/shop_goods.php Outdated Show resolved Hide resolved
src/engine/Default/shop_goods.php Outdated Show resolved Hide resolved
src/engine/Default/shop_goods.php Outdated Show resolved Hide resolved
@Page- Page- force-pushed the port-search-consts branch from 4700a59 to 26d59bd Compare January 27, 2021 17:02
@Page- Page- requested a review from hemberger January 27, 2021 17:02
@Page- Page- merged commit 91d142c into smrealms:master Jan 27, 2021
@Page- Page- deleted the port-search-consts branch January 27, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants