Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward ref to SVG root tag #184

Closed
gregberge opened this issue Sep 26, 2018 · 0 comments
Closed

Forward ref to SVG root tag #184

gregberge opened this issue Sep 26, 2018 · 0 comments
Labels
enhancement ✨ good first issue 🤙 WIP ⏳

Comments

@gregberge
Copy link
Owner

As suggested in #99, we should forward ref to the SVG root tag. Since it is a breaking change because it changes the minimal version of React to 16.3 it will be released in v3.
@gregberge gregberge mentioned this issue Sep 26, 2018
Closed
gregberge added a commit that referenced this issue Sep 30, 2018
@gregberge
feat: use React.forwardRef
30498f4 
BREAKING CHANGE:

"ref" option now uses `React.forwardRef`. You don't have to use "svgRef"
prop, just use "ref" and it will work. `React.forwardRef` requires React
> 16.3.

Closes #184
gregberge added a commit that referenced this issue Sep 30, 2018
@gregberge
feat: use React.forwardRef
03c7b56 
BREAKING CHANGE:

"ref" option now uses `React.forwardRef`. You don't have to use "svgRef"
prop, just use "ref" and it will work. `React.forwardRef` requires React
> 16.3.

Closes #184
gregberge added a commit that referenced this issue Oct 1, 2018
@gregberge
feat: use forwardRef on React Native
4bdd989 
See #184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ good first issue 🤙 WIP ⏳
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregberge