Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use forwardRef api for icons #99

Closed
lifeiscontent opened this issue May 20, 2018 · 8 comments
Closed

use forwardRef api for icons #99

lifeiscontent opened this issue May 20, 2018 · 8 comments
Labels
feature request 🙏

Comments

@lifeiscontent
Copy link
Contributor

I'm wondering if we should use the new forwardRef for the ref option, or if we should create a new option?

What do you think @neoziro
@gregberge
Copy link
Owner

We should use forwardRef but it is only compatible with React 16. We should probably use an option to choose the behaviour of it.

@lifeiscontent
Copy link
Contributor Author

@neoziro any suggestions?

@lifeiscontent
Copy link
Contributor Author

I believe there's a compat layer for forward Ref.

@lifeiscontent
Copy link
Contributor Author

@neoziro nvm on polyfill. React team doesn't seem to have published a backward polyfill package.

@gregberge
Copy link
Owner

It is not polyfillable.

@lifeiscontent
Copy link
Contributor Author

@neoziro maybe we let them specify the version of react they're using with the ref option? defaulting to 15?

@gregberge
Copy link
Owner

I need to investigate what is possible to do.

@gregberge gregberge mentioned this issue Sep 26, 2018
Closed
@gregberge
Copy link
Owner

Follow up in #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request 🙏
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lifeiscontent @gregberge