Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic if no valid source address is found for the DNS query #987

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

thvdveld
Copy link
Contributor

Don't panic if there is no valid source address for the DNS query. The state of the query is set to Failed instead, and the query is abandoned.

Fixes #941 .

Don't panic if there is no valid source address for the DNS query. The
state of the query is set to `Failed` instead and the query is
abandoned.
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.26%. Comparing base (4990fb9) to head (115fd06).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/socket/dns.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   79.27%   80.26%   +0.98%     
==========================================
  Files          81       81              
  Lines       26926    28307    +1381     
==========================================
+ Hits        21346    22720    +1374     
- Misses       5580     5587       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Dirbaio Dirbaio added this pull request to the merge queue Sep 16, 2024
Merged via the queue into smoltcp-rs:main with commit dee8975 Sep 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Panic when solving URI with mDNS
2 participants