Change mutability of RxToken's consume argument.
#924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
approved these changes
Apr 24, 2024
lmbollen
force-pushed
the
rx-token-consume-mutability
branch
from
54fee5d
to
6fbd46c
Compare
|
Had to add: extern crate alloc;
use alloc::vec::Vec;to |
whitequark
reviewed
Jul 17, 2024
This drops the requirement that we can mutate the receive buffer, which is not always te case.
lmbollen
force-pushed
the
rx-token-consume-mutability
branch
from
6fbd46c
to
4055a19
Compare
|
@whitequark I think we're ready to merge :) But I have no rights. |
martijnbastiaan
added a commit
to bittide/bittide-hardware
that referenced
this pull request
Nov 21, 2024
martijnbastiaan
added a commit
to bittide/bittide-hardware
that referenced
this pull request
Nov 21, 2024
martijnbastiaan
added a commit
to bittide/bittide-hardware
that referenced
this pull request
Nov 21, 2024
martijnbastiaan
added a commit
to bittide/bittide-hardware
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request drops the requirement that we can mutate the receive buffer.
I noticed issue #443 already discussed this, but was closed without making the change. Even though the suggestion was to change it.