Implement join/leave_multicast_group() for IPv6
#914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasvr
force-pushed
the
lucas/multicastv6
branch
2 times, most recently
from
d5939b8
to
dc64814
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
+ Coverage 79.96% 79.97% +0.01%
==========================================
Files 82 81 -1
Lines 28378 27831 -547
==========================================
- Hits 22693 22259 -434
+ Misses 5685 5572 -113 ☔ View full report in Codecov by Sentry. |
lucasvr
force-pushed
the
lucas/multicastv6
branch
from
dc64814
to
6c06cd9
Compare
This patch rebases @jgallagher's to the tip of the main branch, adding support for IPv6 multicast groups. As in the original PR, it is only possible to join groups by sending an initial MLDv2 Report packet. It is not yet possible to resend the change report, leave groups, respond to queries, etc.
Also, modify `test_join_ipv6_multicast_group()` so that it joins the mDNS multicast group instead of 0xfe80::1. Because the lower 24 bits of 0xfe80::01 match the lower part of the IPv6 address assigned to the test device by `crate::tests::setup()`, `has_multicast_group()` would always returns `true`.
lucasvr
changed the title
join_multicast_group() for IPv6join/leave_multicast_group() for IPv6
|
Folks, I would appreciate if someone could review this PR. For symmetry, in addition to @jgallagher's original pull request, this PR implements |
thvdveld
requested changes
Apr 19, 2024
No part of the code uses this anymore.
thvdveld
requested changes
Apr 22, 2024
- Handle payload copy outside of mld::AddressRecordRepr::emit() - On unit test, use the parsed Hop-by-Hop option instead of checking that the wire representation of the two structures is the same - Minor code changes
thvdveld
reviewed
May 7, 2024
- Split mldv2_router_alert() in two, adding a new function named push_padn_option(u8) to emit a PadN hop-by-hop option after any other options have been pushed already - When emiting ReportRecordReprs, remove the conditional block that attempted to copy payload data over the destination record
|
I think we can merge this now. Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch rebases @jgallagher's PR #602 to the tip of the main branch, adding support for IPv6 multicast groups.
As in the original PR, it is possible to join groups by sending an initial MLDv2 Report packet. In addition to PR #602, this PR also implements
leave_multicast_group().It is not yet possible to resend the change report or respond to queries.