ICMP socket: split ICMPv4/v6 accept and process #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 79.75% 79.78% +0.02%
==========================================
Files 80 80
Lines 28033 28053 +20
==========================================
+ Hits 22358 22382 +24
+ Misses 5675 5671 -4 ☔ View full report in Codecov by Sentry. |
Splitting the accept and process functions into separate functions for IPv4 and IPv6 allows us to avoid the `IpRepr` enum and instead use the `Ipv4Repr` and `Ipv6Repr` structs directly. This reduces the binary size by 1.5 KiB.
thvdveld
force-pushed
the
icmp-split-v4-and-v6
branch
from
628950a
to
951b59b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the accept and process functions of the ICMP socket into separate functions for IPv4 and IPv6 allows us to avoid the
IpReprenum and instead use theIpv4ReprandIpv6Reprstructs directly.This leads to a reduction in binary size:
example/server: 197.3KiB -> 195.9KiB
example/client: 198.0KiB -> 196.7KiB
example/sixlowpan: 194.7KiB -> 193.3KiB
Since the functions are only
pub(crate), the impact is only internal.