Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't handle empty packets #866

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

thvdveld
Copy link
Contributor

@thvdveld thvdveld commented Dec 5, 2023

Smoltcp should not handle empty packets.

Smoltcp should not handle empty packets.
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (36a143d) 79.62% compared to head (f74c5f0) 79.63%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/iface/interface/mod.rs 78.57% 3 Missing ⚠️
src/socket/dns.rs 0.00% 1 Missing ⚠️
src/socket/udp.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   79.62%   79.63%   +0.01%     
==========================================
  Files          78       78              
  Lines       28043    28047       +4     
==========================================
+ Hits        22329    22335       +6     
+ Misses       5714     5712       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thvdveld thvdveld added this pull request to the merge queue Dec 11, 2023
Merged via the queue into smoltcp-rs:main with commit 4700f2a Dec 11, 2023
14 checks passed
@thvdveld thvdveld deleted the dont-process-empty-packets branch December 11, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant