refactor: move IPv6 HBH in own module #827
Conversation
The Ipv6HopByHopRepr was previously the same as an Ipv6ExtHeader. However, the RFC says that hop-by-hop options might change, which is not possible with the current implementation. I added a representatation for the Hop-by-Hop header, which has an heapless Vec of parsed options. This way, we can modify the options when needed. The function of the Ipv6ExtHeader struct is now purely for parsing the ext header type and the length. It also returns a pointer to the data it holds, which must be parsed by the correct extension header representations.
Codecov Report
@@ Coverage Diff @@
## main #827 +/- ##
==========================================
+ Coverage 79.65% 79.80% +0.14%
==========================================
Files 72 72
Lines 27862 27991 +129
==========================================
+ Hits 22193 22337 +144
+ Misses 5669 5654 -15
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hm, why are we using both |
|
It looks like |
|
I think that'll be hard to pass the managed buffer to the parser no? The parse function should get a managed buffer from the interface, so then the interface inner should have a managed buffer, so then we need to implement a function that gives a managed buffer to the interface, which we then have to check if it was given by the user or not, and so on. I think it's simpler using the heapless::Vec in the wire module. I agree that using managed buffers for fragmentation and socket buffers is a must. |
|
Yeah, on second thought you're right, go ahead. |
The Ipv6HopByHopRepr was previously the same as an Ipv6ExtHeader. However, the RFC says that hop-by-hop options might update en route, which is not possible with the current implementation.
I added a representation for the Hop-by-Hop header, which has a heapless Vec of parsed options. This way, we can modify the options when needed.
The function of the Ipv6ExtHeader struct is now purely for parsing the ext header type and the length. It also returns a pointer to the data it holds, which must be parsed by the correct extension header representations.