dhcpv4: use offered ip in requested ip option #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whitequark would it be possible to squeeze this in be fore the next release? Not sure who's best to review this as @astro is busy atm I think. |
|
Okay, I'll review it before that. |
astro
reviewed
Jan 5, 2020
|
@whitequark I see this didn't make it into 0.6 :(, Will this now have to wait till 0.7 or could it make it into a patch release? (I don't think this is breaking change) |
|
We can make a patch release just fine. I was just really low on time lately--as soon as I review this, I can cut a release for you. |
|
Thanks. I appreciate the time you've taken to review my PR's thus far. Let me know if there is anything I can do to help. |
astro
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of configuring the ifaces ip address when a dhcp server offers
and ip, the client now use the requested_ip dhcp option, based on the offered ip
(yiaddr). The user now only has to configure the iface once the dhcp
transaction has completed (Ack'd).
Closes #302.
cc: @astro