Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, I tried using async-io in a tokio application because I wanted to leverage udp_socket functionalities. My application suffered very poor performances sending data, so I investigated this.
I have found poll_writable() to be slow, from 0 to 1200ms, very randomly.
The problem is that at each poll_iteration the
ticks
are saved again. At the time of saving them the reactor has already updated the tick value. The next time the function is runs, the new tick is almost always within the last two saved. This is visible in the following log generated with these changesThe test I added would previously tick 1400 times on my machine before the future became Ready. With the fix It takes 2 or 3 ticks.
This logic has been re-implemented for
async fn writable()
, which is where I took the idea of the fix from. In that case infact, the ticks are not updated if they are already saved.