Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated versioneer to v0.29 #123

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

kristinazvolanek
Copy link
Contributor

Closes #122

Proposed Changes

  • Updated versioneer to v0.29
  • Added try/except statement for find_module command, which was removed from Python 3.12 and replaced with find_spec
  • Installed phys2cvr locally with Python 3.12 and tested command line implementation (with input data) -- it works!

Change Type

  • bugfix (+0.0.1)
  • [] minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [] [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.

Copy link
Owner

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add your new infra contribution to the all-contributorsrc file, and un-draft the PR?

@smoia smoia added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Sep 10, 2024
@kristinazvolanek kristinazvolanek marked this pull request as ready for review September 17, 2024 17:39
@kristinazvolanek
Copy link
Contributor Author

Done and done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update versioneer for newer Python versions
2 participants