Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve security vulnerability and upgrade to go1.18 CVE-2022-27191 #250

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

breneckd
Copy link
Contributor

@breneckd breneckd commented Apr 13, 2022

Upgrade go to 1.18 to resolve vulnerability CVE-2022-27191

@breneckd breneckd changed the title resolve security vulnerability and upgrade to go1.18 Resolve security vulnerability and upgrade to go1.18 CVE-2022-27191 Apr 13, 2022
@Thiht
Copy link
Collaborator

Thiht commented Apr 13, 2022

@breneckd
Copy link
Contributor Author

@breneckd
Copy link
Contributor Author

Cant see any errors in the CI test not sure why its failing?

@breneckd
Copy link
Contributor Author

@Thiht

@Thiht
Copy link
Collaborator

Thiht commented Apr 27, 2022

oops, sorry I missed it.

It says the SONAR_TOKEN env variable is missing, but it's declared in the settings... I'll have to dig to find out why

@Thiht
Copy link
Collaborator

Thiht commented Apr 27, 2022

I think it's because your branch is on a fork, so secrets are not accessible in the github actions in this case.
I'll merge on master, it should work

@Thiht Thiht merged commit 3f1407b into smocker-dev:master Apr 27, 2022
@breneckd
Copy link
Contributor Author

Oh, just assumed only could fork repo. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants