Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thiht/issue27 #239

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Thiht/issue27 #239

merged 2 commits into from
Feb 7, 2022

Conversation

Thiht
Copy link
Collaborator

@Thiht Thiht commented Feb 5, 2022

Fixes #27

Tested with a self signed cert generated with:

openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -sha256 -days 365 -nodes

@Thiht Thiht requested a review from gwleclerc February 5, 2022 22:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.9% 40.9% Coverage
0.0% 0.0% Duplication

@Thiht Thiht merged commit 1b92e58 into master Feb 7, 2022
@Thiht Thiht deleted the Thiht/issue27 branch February 7, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwleclerc gwleclerc gwleclerc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HTTPS
2 participants
@Thiht @gwleclerc