Update blob defaults for protocol tests #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
approved these changes
Nov 15, 2024
MYoung25
pushed a commit
to MYoung25/smithy
that referenced
this pull request
Nov 29, 2024
Updates blob defaults in protocol tests to use valid Base64 strings. Also updates the associated default documentation to make this requirement clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the blob defaults in a few protocol tests to conform with expected values.
Also adds documentation on the expected constraints on default blob values and a validator to warn on incorrect values. A warning is used instead of an error as this could otherwise be a breaking change for consumers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.