Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-tests): fix protocol test HttpHandler #920

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Sep 8, 2023

Issue #, if available:

N/A.

Description of changes:

Update protocol test stub to implement HttpHandler.

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase
Copy link
Contributor

srchase commented Sep 8, 2023

Can you link to the issue that this is fixing for the protocol tests?

@syall
Copy link
Contributor Author

syall commented Sep 8, 2023

Can you link to the issue that this is fixing for the protocol tests?

The changes in a03026e require all HttpHandler implementations to implement updateHttpClientConfig() and httpHandlerConfigs().

This was a miss in the protocol test stub for RequestSerializationTestHandler and ResponseDeserializationTestHandler.

@syall syall merged commit c2298c9 into smithy-lang:main Sep 8, 2023
@syall syall deleted the fix-protocol-test-http-handler branch September 8, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants