fix for operationContextParam codegen #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Dec 19, 2024
| */ | ||
| export interface OperationContextParamInstruction { | ||
| type: "operationContextParams"; | ||
| get(input: any): any; |
There was a problem hiding this comment.
can I assume that the path expression is solely based on the input? No other parameters are needed, right?
There was a problem hiding this comment.
Yes. As per internal documentation
The
operationContextParamstrait defines one or more context parameters that MUST be bound to values specified in the operation input using a JMESPath expression
kuhe
force-pushed
the
fix/operationContextParams
branch
from
b40efff to
3b3ba74
Compare
kuhe
commented
Dec 19, 2024
| @@ -344,7 +344,7 @@ private void generateEndpointParameterInstructionProvider() { | |||
| operationContextParamValues.forEach((name, jmesPathForInputInJs) -> { | |||
| writer.write( | |||
| """ | |||
| $L: { type: \"operationContextParams\", name: $L }, | |||
| $L: { type: \"operationContextParams\", get: (input?: any) => $L }, | |||
There was a problem hiding this comment.
These need to be functions because there is no this at the time the instruction is evaluated. The instruction sits in the global/module scope due to the use of classBuilder to create commands.
export class XCommand extends $Command.
classBuilder<...>()
.ep({
...commonParams,
MemberName: { type: "operationContextParams", get: (input?: any) => ... },
})
...
.build() {
protected declare static __types: { ... }
}
trivikr
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal JS-5629
This PR fixes codegen for operationContextParam by changing the path expression result into a mapping function based on the command's input. The getter functions are made non-throwing so as not to perform unintentional client side validation.