feat: recursively merge package.json scripts field from build configuration #1372
+18
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #1125
Description of changes:
One of the build options for code generation is:
packageJson
| required=No | Custom package.json properties that will be merged with the base package.json. The default value is an empty object.Because of shallow merging, it is difficult for example to merge script entries like
This PR changes the behavior to recursive merging for only the
scripts
field. I do not expect anyone to be relying on the existing shallow merge behavior, because every code generated field in"scripts"
is there for a reason.More specific customization of the package.json object can be done after the build, if needed.
Recursive merging is not done for other fields, to avoid mixing user and generated nested fields in e.g. authorship metadata or bundler instruction metadata.