feat: improve support for fetch and web-streams in Node.js #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
requested changes
May 1, 2024
Co-authored-by: Trivikram Kamat <[email protected]>
Co-authored-by: Trivikram Kamat <[email protected]>
kuhe
changed the title
trivikr
approved these changes
May 7, 2024
|
I tested this by running our dynamodb e2e suite using |
syall
approved these changes
May 8, 2024
kuhe
added a commit
to kuhe/smithy-typescript
that referenced
this pull request
May 28, 2024
…ng#1256) * feat: improve fetch-http-handler compatibility in Node.js * add changeset * unit tests * formatting * Update packages/fetch-http-handler/README.md Co-authored-by: Trivikram Kamat <[email protected]> * Update packages/node-http-handler/src/stream-collector/index.ts Co-authored-by: Trivikram Kamat <[email protected]> * test: modify conditional unit tests --------- Co-authored-by: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-js-v3#4619
Description of changes:
streamCollectorandsdkStreamMixincomponents that are part of the client config, specifically the SerdeContext subset, have been modified to allow web streams