Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rust 1.83.0 "elided_named_lifetimes" warning. #3955

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

deven
Copy link
Contributor

@deven deven commented Dec 28, 2024

Compiling aws-config v1.5.12 (.../aws-config)
warning: elided lifetime has a name
--> .../aws-config/src/meta/credentials/chain.rs:117:72
|
117 | fn provide_credentials<'a>(&'a self) -> future::ProvideCredentials<'_>
| -- lifetime 'a declared here ^^ this elided lifetime gets resolved as 'a
|
= note: #[warn(elided_named_lifetimes)] on by default

warning: elided lifetime has a name
--> .../aws-config/src/meta/token.rs:108:60
|
108 | fn provide_token<'a>(&'a self) -> future::ProvideToken<'_>
| -- lifetime 'a declared here ^^ this elided lifetime gets resolved as 'a

warning: elided lifetime has a name
--> .../aws-config/src/sts/assume_role.rs:317:72
|
317 | fn provide_credentials<'a>(&'a self) -> future::ProvideCredentials<'_>
| -- lifetime 'a declared here ^^ this elided lifetime gets resolved as 'a

Motivation and Context

Description

Testing

Checklist

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

   Compiling aws-config v1.5.12 (.../aws-config)
warning: elided lifetime has a name
   --> .../aws-config/src/meta/credentials/chain.rs:117:72
    |
117 |     fn provide_credentials<'a>(&'a self) -> future::ProvideCredentials<'_>
    |                            -- lifetime `'a` declared here              ^^ this elided lifetime gets resolved as `'a`
    |
    = note: `#[warn(elided_named_lifetimes)]` on by default

warning: elided lifetime has a name
   --> .../aws-config/src/meta/token.rs:108:60
    |
108 |     fn provide_token<'a>(&'a self) -> future::ProvideToken<'_>
    |                      -- lifetime `'a` declared here        ^^ this elided lifetime gets resolved as `'a`

warning: elided lifetime has a name
   --> .../aws-config/src/sts/assume_role.rs:317:72
    |
317 |     fn provide_credentials<'a>(&'a self) -> future::ProvideCredentials<'_>
    |                            -- lifetime `'a` declared here              ^^ this elided lifetime gets resolved as `'a`
@deven deven requested a review from a team as a code owner December 28, 2024 18:59
@landonxjames
Copy link
Contributor

@landonxjames landonxjames added this pull request to the merge queue Dec 28, 2024
Merged via the queue into smithy-lang:main with commit e2d9fe8 Dec 28, 2024
40 of 42 checks passed
@deven deven deleted the fix-lifetime-warning branch December 28, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants