Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registerGenerateCargoWorkspaceTask() to declare the output file. #3954

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

deven
Copy link
Contributor

@deven deven commented Dec 28, 2024

Motivation and Context

When I tried to build the main branch with ./gradlew assemble, I got the following error. This commit fixes the problem.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':aws:sdk-adhoc-test:generateCargoWorkspace'.
> java.io.FileNotFoundException: /home/deven/git/smithy-rs/aws/sdk-adhoc-test/build/smithyprojections/sdk-adhoc-test/Cargo.toml (No such file or directory)

Description

Fixes registerGenerateCargoWorkspaceTask() to declare the output file correctly when creating the Cargo.toml file, so Gradle can track the dependencies properly.

Testing

Without this change, ./gradlew clean; ./gradlew assemble failed every time. With this change, it works.

Checklist


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@deven deven requested review from a team as code owners December 28, 2024 07:37
@landonxjames
Copy link
Contributor

@landonxjames landonxjames added this pull request to the merge queue Dec 28, 2024
Merged via the queue into smithy-lang:main with commit 7987374 Dec 28, 2024
40 of 42 checks passed
@deven deven deleted the fix-generate-cargo-workspace branch December 28, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants