Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin smithy-rs-tool-common with lockfile #3942

Merged
merged 2 commits into from
Dec 17, 2024
Merged

pin smithy-rs-tool-common with lockfile #3942

merged 2 commits into from
Dec 17, 2024

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Dec 16, 2024

Description

Seeing preview build failures across the board. Looks like [email protected] was released a few hours ago and comes with a new MSRV of 1.81. We don't have a lockfile for smithy-rs-tool-common for some reason. This PR adds one.

~/sandbox/rs/smithy-rs/tools/ci-build/smithy-rs-tool-common on main ✗                                                                            [41d648dd6]  12:14
> cargo check
error: rustc 1.78.0 is not supported by the following package:
  [email protected] requires rustc 1.81
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.78.0

Added a lockfile and downgraded home:

> cargo update [email protected] --precise 0.5.9

Testing

Build locally + CI.

Questions

Lockfiles do not appear to be updated automatically for anything under ci-build unless I'm missing something. This is probably fine as our use of lockfiles is intended to catch issues with consumers of smithy-rs and the SDK not our own internal tooling.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aajtodd aajtodd requested review from a team as code owners December 16, 2024 17:26
Copy link
Contributor

@landonxjames landonxjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locks home to 0.5.9, LGTM

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi enabled auto-merge December 17, 2024 16:20
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 9b2236a Dec 17, 2024
43 of 44 checks passed
@Velfi Velfi deleted the fix-tools branch December 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants