Allow multiple releases per day in the smithy-rs repository #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
reviewed
Oct 14, 2024
This reverts commit fa0a188.
ysaito1001
commented
Oct 15, 2024
| @@ -202,7 +208,7 @@ jobs: | |||
| # to retry a release action execution that failed due to a transient issue. | |||
| # In that case, we expect the commit to be releasable as-is, i.e. the changelog should have already | |||
| # been processed. | |||
| git fetch --unshallow | |||
| git fetch | |||
There was a problem hiding this comment.
FYI, specifying --unshallow in a repository with fetch-depth: 0 will fail with the following error:
fatal: --unshallow on a complete repository does not make sense
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Oct 16, 2024
landonxjames
approved these changes
Oct 16, 2024
david-perez
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, we can only make one
smithy-rsrelease per day, and this restricts our ability to respond to urgent issues. This PR lifts that limitation, allowing us to make multiple releases per day.Description
The core of this change is in the
rendersubcommand ofchangelogger. When generating a date-based release tag, it now checks for existing tags on the same day. If a tag already exists, therendersubcommand will append a numerical suffix to ensure the new tag is unique.In fact, appending a numerical suffix to make a release tag unique has been a workaround in our release pipeline (outside the
smithy-rsrepository) for quite some time. With the changes in this PR, we can eliminate that temporary solution from the release pipeline.Now that
changeloggerrequires access to previous tags, CI steps that rungenerate-smithy-rs-releaseneed to checkout thesmithy-rsrepository with all tags (fetch-depth: 0is for that purpose).Testing
changeloggerchangeloggerinto thinking that it has to bump a release tag)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.