[Issue 3161] Implement Debug on DateTime #3614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
According to #3161 , the Debug output was in a marginally legible format.
#3161
Description
Since there's no expected difference between
DebugandDisplayfor date_time, thefmt::Debugfordate_timecalls the already implementedDisplay.Testing
I added unit tests, and ran
cargo testwithin therust-runtimedirectory.Aarch64 mac terminal -
$ cd rust-runtime && cargo testA single test failed:
client::waiters::backoff::tests::backoff_with_seeded_jitterat first. After rebasing on upstream, the failure went away. Thanks for the fix.Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.