Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messaging for auth scheme selection #3277

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Improve error messaging for auth scheme selection #3277

merged 6 commits into from
Dec 4, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Dec 1, 2023 •
edited
Loading

This patch adds a stack-allocated list of explored auth schemes and the reason each didn't work to the auth orchestrator so that its error message is much easier to decipher.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti requested a review from a team as a code owner December 1, 2023 01:49
@jdisanti jdisanti requested a review from a team as a code owner December 1, 2023 01:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh
rcoh approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! We should explore other places to use this pattern—I was hoping to build this generally with "error collector" but maybe we could find another way to generally build it into the orchestrator

aws/sdk/integration-tests/dynamodb/tests/auth_scheme_error.rs Outdated Show resolved Hide resolved
rust-runtime/aws-smithy-runtime/src/client/orchestrator/auth.rs Outdated Show resolved Hide resolved
rust-runtime/aws-smithy-runtime/src/client/orchestrator/auth.rs Outdated Show resolved Hide resolved
rust-runtime/aws-smithy-runtime/src/client/orchestrator/auth.rs Outdated Show resolved Hide resolved
rust-runtime/aws-smithy-runtime/src/client/orchestrator/auth.rs Show resolved Hide resolved
ysaito1001
ysaito1001 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@ysaito1001 ysaito1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greatly improves the messaging!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh
rcoh approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore my comment, it was from a bad diff github gave me

CHANGELOG.next.toml Show resolved Hide resolved
@jdisanti jdisanti added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit 85d2621 Dec 4, 2023
41 checks passed
@jdisanti jdisanti deleted the jdisanti-improve-missing-creds-error branch December 4, 2023 19:53
@jdisanti jdisanti mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysaito1001 ysaito1001 ysaito1001 approved these changes

@rcoh rcoh rcoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdisanti @rcoh @ysaito1001 @Velfi